Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Clarify onBeforeRender() and onAfterRender(). #21124

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 21, 2021

Related issue: Fixed #11306.

Description

This PR clarifies that only renderable objects can fire onBeforeRender() and onAfterRender().

@mrdoob mrdoob added this to the r125 milestone Jan 21, 2021
@mrdoob mrdoob merged commit 0f3e6f6 into mrdoob:dev Jan 21, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jan 21, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGLRenderer: onAfterRender() and onBeforeRender() are not called for Object3D and Group.
2 participants