Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Face3: Remove from core. #21164

Merged
merged 1 commit into from Jan 28, 2021
Merged

Face3: Remove from core. #21164

merged 1 commit into from Jan 28, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 28, 2021

Related issue: see #21161 (comment)

Description

Moves Face3 to examples/jsm/deprecated/Geometry.js.

@mrdoob mrdoob added this to the r126 milestone Jan 28, 2021
@mrdoob mrdoob merged commit 945ecfd into mrdoob:dev Jan 28, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jan 28, 2021

Thanks!

@drcmda
Copy link
Contributor

drcmda commented Feb 5, 2021 •
edited

@Mugen87 It looks like Face3 is not exported, only Geometry. Could it be exported so that older code can still run?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Feb 5, 2021

Geometry is not exported, see https://jsfiddle.net/y37kwnb0/

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Feb 5, 2021

Oh wait! Sorry, I know what you mean. I'll change it.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Feb 5, 2021

33497f2

@YunosukeY YunosukeY mentioned this pull request Feb 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r126
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mugen87 @mrdoob @drcmda