Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix4: generalize .makeShear() method #21822

Merged
merged 3 commits into from
May 13, 2021
Merged

Matrix4: generalize .makeShear() method #21822

merged 3 commits into from
May 13, 2021

Conversation

WestLangley
Copy link
Collaborator

@WestLangley WestLangley commented May 12, 2021 •
edited
Loading

The current .makeShear() method is too restrictive to be useful.

Even the most trivial shear matrix

1,   0.5,  0,   1
0,   1,    0,   1
0,   0,    1,   1
0,   0,    0,   1

is not supported.

This PR supports a generalized shear matrix.

@WestLangley WestLangley added this to the r129 milestone May 12, 2021
@mrdoob mrdoob merged commit 5ad39fd into mrdoob:dev May 13, 2021
@mrdoob
Copy link
Owner

mrdoob commented May 13, 2021

Thanks!

@WestLangley WestLangley deleted the dev-shear branch May 13, 2021 11:44
@joshuaellis joshuaellis mentioned this pull request May 27, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r129
Development

Successfully merging this pull request may close these issues.
2 participants
@WestLangley @mrdoob