Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: Clean up #22029

Merged
merged 2 commits into from Jun 21, 2021
Merged

Examples: Clean up #22029

merged 2 commits into from Jun 21, 2021

Conversation

WestLangley
Copy link
Collaborator

Follow-on to #21969, which removed the premultipliedAlpha test from webgl_materials_physical_transmission.html.

WestLangley
WestLangley commented Jun 20, 2021
View reviewed changes
examples/webgl_materials_physical_transmission.html
@@ -65,7 +65,6 @@
renderer.outputEncoding = THREE.sRGBEncoding;

scene = new THREE.Scene();
scene.background = hdrEquirect;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: background was not removed. There were two backgrounds specified.

@WestLangley
Copy link
Collaborator Author

I am not a fan of these examples that rotate the object unnecessarily. They serve only to obfuscate potential problems.

I'd recommend a GUI to toggle-off the animation -- resetting the rotation to zero.

@WestLangley
Copy link
Collaborator Author

WestLangley commented Jun 21, 2021 •
edited

Updated screen shot is not correct... Not sure what is going on...

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 21, 2021

Updated screen shot is not correct... Not sure what is going on...

Have you tried npm i before making the screenshot?

@WestLangley
Copy link
Collaborator Author

@Mugen87 I did, and the generated screenshot is still not correct. Can you give it a try?

@mrdoob
Copy link
Owner

mrdoob commented Jun 21, 2021 •
edited by WestLangley

@WestLangley can you try running npm i inside the test/ folder?

@mrdoob mrdoob added this to the r130 milestone Jun 21, 2021
@mrdoob mrdoob merged commit 1debe8b into mrdoob:dev Jun 21, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jun 21, 2021

Thanks!

@WestLangley
Copy link
Collaborator Author

@WestLangley can you try running npm i inside the test/ folder?

Thanks! That fixed it.

@WestLangley WestLangley deleted the dev_examples branch June 21, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r130
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WestLangley @Mugen87 @mrdoob