ObjectLoader: Moved json handling to geometries #22040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob
commented
Jun 24, 2021
| console.warn( 'THREE.ObjectLoader: Unsupported geometry type "' + data.type + '"' ); | ||
| if ( data.type in Geometries ) { | ||
|
|
||
| geometry = Geometries[ data.type ].fromJSON( data, shapes ); |
There was a problem hiding this comment.
Hmm, this is not the prettiest...
Only ExtrudeGeometry and ShapeGeometry uses the shapes parameter 🤔
There was a problem hiding this comment.
We could consider to resolve the shape UUIDs in ObjectLoader and then store the resulting shapes in the data object. In this way, all fromJSON() method would have a common signature.
However, it would be necessary to check for data.shapes in ObjectLoader for each geometry.
There was a problem hiding this comment.
Yeah, I'm not sure what's better...
I think I'll try the current approach for now.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the primitives json handling out of
ObjectLoader.