LoaderUtils: Add resolveURL(). #22707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlong
changed the title
|
Would it be an option to put this method into LoaderUtils instead? It feels a bit inconsistent (regarding other loaders) to transform such helpers to public loader methods. |
|
Sounds good to me! I was thinking that as well, but opted against it since it's really only used in the GLTFLoader. I'll move it over if there's support for that. |
Mugen87
approved these changes
Oct 21, 2021
Mugen87
changed the title
donmccurdy
approved these changes
Oct 22, 2021
|
Thanks! |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes the
resolveURLfunction on theGLTFParserclass. This makes it easier to reuse this code in GLTFLoader plugins for loading assets that use relative uris.For example in three-omi I've copied the function into our codebase rather than reusing the three.js implementation.