New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in webgpu/constants.js #22795

Merged

mrdoob merged 1 commit into mrdoob:dev from takahirox:FixTypo

Nov 7, 2021

Collaborator

takahirox commented Nov 7, 2021 •

edited

Loading

Description

This PR fixes a typo in examples/jsm/renderers/webgpu/constants.js.

BRGA8Unorm: 'bgra8unorm',
BRGA8UnormSRGB: 'bgra8unorm-srgb',

The values are bgra* but the keys are BRGA*. I think the keys should be BGRA* unless they are intentional.


          Fix typo in webgpu/constants.js

b48408b

mrdoob added this to the r135 milestone

mrdoob merged commit e683d19 into mrdoob:dev

Owner

mrdoob commented Nov 7, 2021

Thanks!

takahirox deleted the FixTypo branch

November 7, 2021 03:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet