Editor: Preview pure skeleton. #22858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonnavis
changed the title
Mugen87
reviewed
Nov 19, 2021
editor/js/Editor.js
Outdated
| @@ -424,6 +424,10 @@ Editor.prototype = { | |||
|
|
|||
| helper = new THREE.SkeletonHelper( object.skeleton.bones[ 0 ] ); | |||
|
|
|||
| } else if ( object.isBone && ( !object.parent || !object.parent.isBone ) ) { | |||
There was a problem hiding this comment.
I think this can be simplified like so:
} else if ( object.isBone && ( object.parent?.isBone !== true ) ) {There was a problem hiding this comment.
BTW: The policy for testing is* flags looks like so:
object.isBone === true // detecting all bones
object.isBone !== true // detecting all 3D objects except for bones
Mugen87
approved these changes
Nov 19, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let editor can preview pure skeleton file, which has not SkinnedMesh.
Such as some animation pack files downloaded from https://www.mixamo.com/ :
Sword and Shield Pack.zip