Fix WebXR Darkness and Non-Stencil Invalid GL Layer

[HexaField]

Related issue: #22558

Description

• solves webxr darkness introduced in Clean up WebXR manager by calling setRenderTarget #22558
• solves stencil crash due to changing DEPTH_COMPONENT24 to DEPTH_COMPONENT16

This contribution is funded by XRFoundation.

[mrdoob]

Thanks!

[HexaField]

I have a follow up I was just about to push that sets encoding to renderer,outputEncoding, right now this is somewhat limited. I will create a follow up PR unless you want to unmerged this? Sorry, just realised it.

[mrdoob]

A new PR is ok 👍

[cabanier]

It seems that the WebXR output is too light with this change.
For instance, ballshooter is much lighter in VR than it is in 2D on both the Oculus browser and desktop mac.

Maybe we should change the PR so we let authors decide if they want to use sRGB encoding.
Also, this code introduces a bug with multisampled renderbuffers because the format of the WebXR texture is still sRGB. This will cause an error on devices that would use that path. (AFAIK there are none at the moment)

[HexaField]

It seems that the WebXR output is too light with this change. For instance, ballshooter is much lighter in VR than it is in 2D on both the Oculus browser and desktop mac.

Maybe we should change the PR so we let authors decide if they want to use sRGB encoding. Also, this code introduces a bug with multisampled renderbuffers because the format of the WebXR texture is still sRGB. This will cause an error on devices that would use that path. (AFAIK there are none at the moment)

A follow PR has been merged already that pulls the output encoding from the WebGLRenderer passed in.
#22919

[cabanier]

A follow PR has been merged already that pulls the output encoding from the WebGLRenderer passed in. #22919

Ah, yes, this is better.
There is still the issue that sRGB encoding will break browsers that don't implement WEBGL_multisampled_render_to_texture. You can reproduce this by setting hasMultisampledRenderToTexture to false.
To fix this, we need to set the texture format of the WebXR projection layer to sRGB

[mrdoob]

Didn't #22997 fix that? 🤔

[cabanier]

Didn't #22997 fix that? 🤔

No, the texture in the projection layer is always created as RGB.

See https://github.com/mrdoob/three.js/blob/dev/src/renderers/webxr/WebXRManager.js#L284