Docs: Add missing load onProgress behaviour. #22990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure if CubeTextureLoader has incorrect documentation for onProgress as ImageLoader has the following for onProgress "[page:Function onProgress] — This callback function is currently not supported." |
|
Nit: I would say "If the server " instead of "If your server". |
|
I was torn on that myself; I will edit the patch |
Load's onProgress function has an undocumented behaviour. If a server does not set the Content-Length header, the onProgress function sets total to 0. This change documents that behaviour.
dweremeichik
force-pushed
the
loader_onprogress
branch
from
3373e66
to
2ec9366
Compare
Mugen87
approved these changes
Dec 10, 2021
Mugen87
changed the title
gero3
pushed a commit
to gero3/three.js
that referenced
this pull request
Dec 13, 2021
Load's onProgress function has an undocumented behaviour. If a server does not set the Content-Length header, the onProgress function sets total to 0. This change documents that behaviour.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #15584
Description
Load's onProgress function has an undocumented behaviour. If a server does not set the Content-Length header, the onProgress function sets total to 0. This change documents that behaviour. It also corrects an outdated onProgress description for MaterialLoader.