ArcballControls: Remove keydown event listener. #23028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
When is this expected to be released to npm? 😊 |
|
When r136 will be released this month. The planned date is 12.22.2021. |
Cool, thanks! |
gero3
pushed a commit
to gero3/three.js
that referenced
this pull request
Dec 16, 2021
9 tasks
|
I noticed ArcBallControls still attempts to remove the keydown event listener at line 2078. Not sure whether that is a problem though |
|
Good catch! Fixed 4ea1a19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Fixed #23023
Description
Removes the
keydownevent listener ofArcballControlsand implements it on app level.This approach makes less assumptions on how the app wants to save/restore the state of the controls.