WebGLRenderer: Remove RGBM7Encoding and RGBM16Encoding. #23046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
drcmda
pushed a commit
to pmndrs/three-stdlib
that referenced
this pull request
Jan 1, 2022
* fix: remove RGBM7Encoding and RGBM16Encoding Mirrors mrdoob/three.js#23046 * fix(ColorSpaceNode): remove RGBDEncoding Mirrors mrdoob/three.js#23049 * fix: remove RGBEEncoding and RGBEFormat * fix: remove gammaFactor and GammaEncoding Mirrors mrdoob/three.js#23080 * fix: unmangle typo in RGBMLoader
0b5vr
added a commit
to 0b5vr/three-ts-types
that referenced
this pull request
Feb 22, 2022
0b5vr
added a commit
to 0b5vr/three-ts-types
that referenced
this pull request
Feb 22, 2022
THREE.RGBM16Encoding no longer exists, replacing this with RGBMLoader.setMaxRange( 16 ) See: mrdoob/three.js#23046
This was referenced Feb 22, 2022
0b5vr
added a commit
to pixiv/three-vrm
that referenced
this pull request
Feb 22, 2022
Redo of #926 in `dev` See: mrdoob/three.js#23046
joshuaellis
pushed a commit
to three-types/three-ts-types
that referenced
this pull request
Feb 22, 2022
* fix: remove RGBM7Encoding and RGBM16Encoding See: mrdoob/three.js#23046 * test: fix materials-envmaps-hdr.ts THREE.RGBM16Encoding no longer exists, replacing this with RGBMLoader.setMaxRange( 16 ) See: mrdoob/three.js#23046 * refactor: lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23039
Description
This PR removes
RGBM7EncodingandRGBM16Encodingfrom the engine.It is still possible to load RGBM encoded textures with
RGBMLoader. However, it outputs now half-float (default) or float.Since you can't configure
WebGLRenderer.outputEncodingwithRGBM7EncodingandRGBM16Encodinganymore, I've updated the RGBM encoder fiddle to use a raw shader material instead.https://jsfiddle.net/yvfhbeo3/4/
It should give users a hint how to implement RGBM encoding with
three.jsif necessary. It's also easy to change it so RGBD or something is used.