[Feature] sessiongranted support for VRButton to enable in-VR navigation
#23110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cabanier Do you know if this will stay behind a flag for much longer? |
|
I'm going to work with @toji on defining a new spec for immersive navigation. Until that is done and implemented, we will keep this behind a flag. |
|
Should I not merge this then? |
I think it's OK to merge. The holdup is more about providing a trusted UI. The |
|
@cabanier is there a place (new issue in the /navigation repo?) to discuss ideas for that trusted UI? Got some input as well. |
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sessiongrantedevent is the current proposal for immersive web navigation (https://github.com/immersive-web/navigation#api-proposal). While still a proposal and only working in the Oculus Quest browser right now, it allows building connected VR pages (and AR pages, but that's not part of this PR).Description
Navigation between pages was causing the session to exit and the user having to initiate the session again. If already authorized, sessiongranted allows to keep the VR session running instead.
A-Frame has implemented this a while ago already (https://aframe.io/docs/1.2.0/components/link.html) and people are creating nice demos with it, now it's coming to three.js :)
Notes
Currently, session navigation needs to be enabled via chrome://flags/#webxr-navigation-permission in the Oculus browser.