Manual: Improve compatibility with import maps. #23370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If that works that's great! I tried to make a more generic change here (ie, not hardcoding 'three'): https://github.com/greggman/three.js/tree/fix-live-editor-for-r137 |
|
It will be more work to make it export. (I guess skydev no longer works with r137? ... not sure) |
|
Cherry-picked in |
|
Thanks! |
|
Looks like @ycw is looking into it too: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #23363.
Description
This PR fixes the examples of the manual. They should work standalone and in the editor view again.
The script export to sites like jsfiddle is not yet fixed. I've hidden the export button until this feature works again.
@greggman Your pointers were really helpful! I've tried to make the changes to
editor.jsandeditor-settings.jsas simple as possible. There are surely more smart solutions but at least the examples should work again.