Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColladaLoader: Convert color from srgb to linear on load #23401

Merged
merged 8 commits into from
Feb 1, 2022
Merged

ColladaLoader: Convert color from srgb to linear on load #23401

merged 8 commits into from
Feb 1, 2022

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #23283

Description

  • Label color textures as "sRGBEncoding".
  • Convert vertex colors from sRGB to Linear.
  • Convert material and light colors from sRGB to Linear.
  • Change renderer.outputEncoding to "sRGBEncoding" in collada examples.

@gkjohnson gkjohnson mentioned this pull request Feb 1, 2022
Closed
25 tasks
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 1, 2022

You also have to update webgl_loader_kmz. KMZLoader internally uses ColladaLoader.

https://raw.githack.com/gkjohnson/three.js/collada-loader-srgb/examples/webgl_loader_kmz.html

@gkjohnson
Copy link
Collaborator Author

You also have to update webgl_loader_kmz. KMZLoader internally uses ColladaLoader.

Thanks! Just updated.

@Mugen87 Mugen87 added this to the r138 milestone Feb 1, 2022
@mrdoob mrdoob merged commit 2bbe2a6 into mrdoob:dev Feb 1, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 1, 2022

Thanks!

@gkjohnson gkjohnson deleted the collada-loader-srgb branch February 1, 2022 22:05
donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
@gkjohnson @donmccurdy
ColladaLoader: Convert color from srgb to linear on load (mrdoob#23401)
c4e85ef 
* ColladaLoader: label color textures, material colors as sRGB

* ColladaLoader: convert vertex colors

* use outputEncoding = sRGBEncoding in collada examples

* update failing screenshots

* fix deepscan issues

* Update ColladaLoader.js

* update KMZ example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WestLangley WestLangley WestLangley left review comments

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r138
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gkjohnson @Mugen87 @mrdoob @WestLangley