Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Fix style issue in flow. #23439

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Examples: Fix style issue in flow. #23439

merged 1 commit into from
Feb 7, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 7, 2022

Related issue: -

Description

This PR fixes a bug and a few minor style issues in flow.

@marcofugaro
Copy link
Contributor

I think @sunag is copying over that file from here: https://github.com/sunag/flow/blob/master/build/flow.module.js

Maybe it's better to edit the source of the lib to avoid it being replaced next time..

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Feb 7, 2022

@sunag Should I open a PR at your repository? Or do you upstream the PR this time?

@mrdoob mrdoob added this to the r138 milestone Feb 7, 2022
@sunag
Copy link
Collaborator

sunag commented Feb 7, 2022

@Mugen87 You can merge it, I sync this in some another update.

@mrdoob mrdoob merged commit 2abe0d8 into mrdoob:dev Feb 7, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 7, 2022

Thanks!

donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants