Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLProgram: Support logging errors with no line numbers #23843

Merged
merged 1 commit into from
Apr 5, 2022
Merged

WebGLProgram: Support logging errors with no line numbers #23843

merged 1 commit into from
Apr 5, 2022

Conversation

gkjohnson
Copy link
Collaborator

Related issue: --

Description

Sometimes shader errors may have no line numbers and will throw an error on this section of code since exec will return null. On my android phone the error was something like:

Error: Maximum uniform count reached

@mrdoob mrdoob added this to the r140 milestone Apr 5, 2022
@mrdoob mrdoob merged commit 0268396 into mrdoob:dev Apr 5, 2022
@mrdoob
Copy link
Owner

mrdoob commented Apr 5, 2022

Thanks!

@gkjohnson gkjohnson deleted the error-log-fix branch April 18, 2022 14:06
@gkjohnson gkjohnson mentioned this pull request Apr 29, 2022
Closed
@marcofugaro marcofugaro mentioned this pull request May 25, 2022
Closed
@LeviPesin LeviPesin mentioned this pull request May 25, 2022
Merged
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
@gkjohnson @abernier
Support logging errors with no line numbers (mrdoob#23843)
d87814e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r140
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gkjohnson @mrdoob @Mugen87