Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add path tracer, ik library links to libraries and tools page #23876

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

gkjohnson
Copy link
Collaborator

Related issue: --

Description

Add three-gpu-pathtracer and closed-chain-ik links.

@gkjohnson gkjohnson changed the title Docs: Add path tracer, ik library links Docs: Add path tracer, ik library links to libraries and tools page Apr 11, 2022
@Mugen87 Mugen87 added this to the r140 milestone Apr 11, 2022
@mrdoob mrdoob merged commit 8db7a59 into dev Apr 11, 2022
@mrdoob
Copy link
Owner

mrdoob commented Apr 11, 2022

Thanks!

@mrdoob mrdoob deleted the new-libs branch April 11, 2022 17:53
@mrdoob
Copy link
Owner

mrdoob commented Apr 12, 2022

@gkjohnson

What do you think about adding three-gpu-pathtracer and three-mesh-bvh examples in this repo like with ifc.js?

https://threejs.org/examples/?q=ifc#webgl_loader_ifc

So if someone looks for bvh or pathtracing they'll easily find the best solution.

@gkjohnson
Copy link
Collaborator Author

What do you think about adding three-gpu-pathtracer and three-mesh-bvh examples in this repo like with ifc.js?

I've thought about this but I think there's an extra burden. I'd prefer to not have to update the three.js repo with new builds and enjoy being able to release / fix bugs on my own cadence. Making sure that the build isn't broken in time before a three.js release after is also a lot of additional overhead to deal with. I also feel it's good to funnel people to the core project so discussions, issues, and requests can happen in the right place.

The discoverability would be good, though. With import maps being used now it's much more viable to create examples using libraries without a copy of the library being maintained in this project. Ie we could have a path tracer or bvh example that imports the libs from unpkg or skypack. It would also alleviate license compatibility issues - which the two projects in question don't have but some of my JPL open source work does (they are licensed as Apache 2.0 not MIT). And perhaps these could be a separate listing on the examples page.

Maybe it's a different can of worms in it's own way but something to consider to support the growth of external projects from the core library.

@gkjohnson
Copy link
Collaborator Author

@mrdoob @Mugen87 Should I interpret the 👍 as an being interested in adding a BVH or path tracing example or two using unpkg import map dependencies and seeing how it goes? Emoji unclear.

@mrdoob
Copy link
Owner

mrdoob commented Apr 13, 2022

I agree with everything you said, including the unpkg import map approach.
Whatever you're comfortable with 👍

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
…rdoob#23876)

* Update Libraries-and-Plugins.html

* Update Libraries-and-Plugins.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants