Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: Fix transmission render target type check #23885

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

chubei-oppen
Copy link
Contributor

Description

Currently, transmission won't work under

  1. A WebGL2 context without either EXT_color_buffer_half_float or EXT_color_buffer_float support.
  2. A WebGL1 context without EXT_color_buffer_half_float support.

This commit fixes that.

This contribution is funded by OppenFuture Technologies

@Mugen87 Mugen87 added this to the r140 milestone Apr 12, 2022
@mrdoob mrdoob merged commit 34dbd31 into mrdoob:dev Apr 12, 2022
@mrdoob
Copy link
Owner

mrdoob commented Apr 12, 2022

Thanks!

@chubei-oppen chubei-oppen deleted the half branch April 13, 2022 07:27
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants