Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLTFLoader: Honor Firefox version when checking for ImageBitmap. #23909

Merged
merged 4 commits into from
Apr 20, 2022
Merged

GLTFLoader: Honor Firefox version when checking for ImageBitmap. #23909

merged 4 commits into from
Apr 20, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 18, 2022 •
edited

Fixed #23906.

Description

Only use ImageBitmapLoader when the version of Firefox is => 98.

donmccurdy
donmccurdy reviewed Apr 18, 2022
View reviewed changes
Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we have code in ImageBitmapLoader to feature-detect support, at one point? Did that just not work because failure cases in Firefox were hard to detect?

Fine to keep UA-sniffing for now though, thanks!

examples/jsm/loaders/GLTFLoader.js Outdated Show resolved Hide resolved
takahirox
takahirox approved these changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@takahirox takahirox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, if it's ok for others to add a version detection code, too, thanks.

donmccurdy
donmccurdy approved these changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@mrdoob mrdoob added this to the r140 milestone Apr 20, 2022
@mrdoob mrdoob merged commit 54e04e5 into mrdoob:dev Apr 20, 2022
@mrdoob
Copy link
Owner

mrdoob commented Apr 20, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
@Mugen87 @abernier
GLTFLoader: Honor Firefox version when checking for ImageBitmap. (mrd…
7204cd5 
…oob#23909)

* GLTFLoader: Honor Firefox version when checking for ImageBitmap.

* GLTFLoader: Clarify ImageBitmap check.

* GLTFLoader: Clean up.

* GLTFLoader: More clean up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

@takahirox takahirox takahirox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r140
Development

Successfully merging this pull request may close these issues.

ImageBitmapLoader (GLTFLoader) fails in Firefox ESR
4 participants
@Mugen87 @mrdoob @donmccurdy @takahirox