WebXRManager: add undefined check in onSessionEnd() #23984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a null check prior to disconnecting the controller in `onSessionEnd()` as described in #23983
Mugen87
approved these changes
May 2, 2022
mrdoob
reviewed
May 6, 2022
mrdoob
changed the title
KallynGowdy
pushed a commit
to casual-simulation/three.js
that referenced
this pull request
May 24, 2022
* WebXRManager: add null check in onSessionEnd() This commit adds a null check prior to disconnecting the controller in `onSessionEnd()` as described in mrdoob#23983 * Fix spacing for Lint
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* WebXRManager: add null check in onSessionEnd() This commit adds a null check prior to disconnecting the controller in `onSessionEnd()` as described in mrdoob#23983 * Fix spacing for Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a undefined check prior to disconnecting the controller in
onSessionEnd()as described in #23983Fixed #23983
Description
Lack of undefined check for controllers in onSessionEnd causes errors if getController is never called. Undefined check prevents errors