Object3D: granular control of matrix updates with matrixWorldAutoUpdate #24028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodyJasonBennett
changed the title
|
Just saw that LOD objects extend Object3D and already use the autoUpdate property. I thought this might be worth mentioning |
|
For consistency... Should we just name it |
|
I'd much prefer that to just |
CodyJasonBennett
changed the title
CodyJasonBennett
force-pushed
the
feat/object3d-autoupdate
branch
2 times, most recently
from
28e38ac
to
ee254c7
Compare
CodyJasonBennett
force-pushed
the
feat/object3d-autoupdate
branch
from
2b94565
to
bc2fd76
Compare
|
Thanks! |
Merged
3 tasks
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
…te (mrdoob#24028) * feat(Object3D): object-level `autoUpdate` * chore: update docs * fix(Object3D): respect `autoUpdate` in updateMatrixWorld * fix(renderers): respect `camera.autoUpdate` on render * Use strict equal codestyle, respect autoUpdate with `updateParents` * Object3D: rename autoUpdate to matrixWorldAutoUpdate * Global: respect Object3D.matrixWorldAutoUpdate
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
…te (mrdoob#24028) * feat(Object3D): object-level `autoUpdate` * chore: update docs * fix(Object3D): respect `autoUpdate` in updateMatrixWorld * fix(renderers): respect `camera.autoUpdate` on render * Use strict equal codestyle, respect autoUpdate with `updateParents` * Object3D: rename autoUpdate to matrixWorldAutoUpdate * Global: respect Object3D.matrixWorldAutoUpdate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #21387
Description
Currently, all scene objects have their matrices updated in
Object3D#updateWorldMatrixorObject3D#updateMatrixWorldif somehow added to the scene. You can toggle this behavior withScene.autoUpdate, but there's no way to let other objects do the same at any point in the scene graph.This PR moves the
Scene.autoUpdateproperty toObject3D.matrixWorldAutoUpdateto enable object-level opt-out of matrix updates inObject3D#updateWorldMatrixandObject3D#updateMatrixWorld. This behavior extends to matrix updates to cameras and scene objects from renderers.