DDSLoader: Remove FourCC header check.
#24124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FourCC code is missing iff the file contains uncompressed texture and the DDSLoader seems to support uncompressed textures.
|
I think reporting a controlled error is better than producing a real exception. Hence, I would keep the check. It's like when |
|
But it does not produce an exception. |
|
DDSLoader supports uncompressed textures: https://github.com/mrdoob/three.js/blob/dev/examples/jsm/loaders/DDSLoader.js#L190-L198 |
|
Ah... So the problem was that the check was actually not working as intended, neither it was needed? |
|
Yes. Maybe the support for uncompressed textures was added after the check? |
|
It seems that it was already like this in the first implementation of DDSLoader but it was not in the webgl-texture-utils implementation (it did not support uncompressed textures and had broken check). |
|
Sounds good 👍 |
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
FourCC code is missing iff the file contains uncompressed texture and the DDSLoader seems to support uncompressed textures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #24121
Description
FourCC code is missing iff the file contains uncompressed texture and the DDSLoader seems to support uncompressed textures.