WebGLShadowMap: Make test for clipping planes more robust. #24144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trusktr
force-pushed
the
fix-error-with-clipShadows-true
branch
from
f6cfbfc
to
16b1c65
Compare
Mugen87
reviewed
May 27, 2022
Mugen87
changed the title
…anes not yet set to an array
trusktr
force-pushed
the
fix-error-with-clipShadows-true
branch
from
16b1c65
to
26af07f
Compare
Mugen87
approved these changes
May 28, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
…anes not yet set to an array (mrdoob#24144) Co-authored-by: Joe Pea <joe@trusktr.io>
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
…anes not yet set to an array (mrdoob#24144) Co-authored-by: Joe Pea <joe@trusktr.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #XXXX
Description
Without this, a
nullclippingPlanesarray (the default value) causes a runtime error whenclipShadowsistrue.three.js/src/materials/Material.js
Line 49 in 0c26bb4