Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPU: add webgpu_cubemap_adjustments example #24206

Merged
merged 11 commits into from
Jun 8, 2022
Merged

WebGPU: add webgpu_cubemap_adjustments example #24206

merged 11 commits into from
Jun 8, 2022

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jun 8, 2022

Description

  • add webgpu_cubemap_adjustments example
  • fix and improve "multipass" flow on IBL
  • add ColorAdjustmentNode
  • add atan2() to WebGPU
  • others minor fixes

Live

https://raw.githack.com/sunag/three.js/dev-cubemap-adjusts/examples/webgpu_cubemap_adjustments.html

image

Rotate a CubeMap

const rotateYMatrix = new THREE.Matrix4();
rotateYMatrix.makeRotationY( Math.PI );

const customUV = mul( reflectCube, uniform( rotateYMatrix ) );
const cubeNode = cubeTexture( cubeTexture, customUV );

This contribution is funded by Google via Igalia

@sunag sunag added this to the r142 milestone Jun 8, 2022
@sunag sunag marked this pull request as ready for review June 8, 2022 05:43
@sunag sunag merged commit 18fb056 into mrdoob:dev Jun 8, 2022
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
@sunag @abernier
WebGPU: add webgpu_cubemap_adjustments example (mrdoob#24206)
51fa8c0 
* ConvertNode: fix cache if used .tempRead = false

* add webgpu_cubemap_adjusts example

* update title

* webgpu_cubemap_adjustments: name and update example

* add ColorAdjustmentNode

* Revert webgpu_cubemap_mix

* WebGPU: add atan2()

* Nodes: fixes multipass flow

* MaxMipLevelNode: Fix check array if images not loaded

* cleanup
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
@sunag @snagy
WebGPU: add webgpu_cubemap_adjustments example (mrdoob#24206)
596e8b5 
* ConvertNode: fix cache if used .tempRead = false

* add webgpu_cubemap_adjusts example

* update title

* webgpu_cubemap_adjustments: name and update example

* add ColorAdjustmentNode

* Revert webgpu_cubemap_mix

* WebGPU: add atan2()

* Nodes: fixes multipass flow

* MaxMipLevelNode: Fix check array if images not loaded

* cleanup
@Methuselah96 Methuselah96 mentioned this pull request Jan 18, 2024
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 left review comments

@LeviPesin LeviPesin LeviPesin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r142
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sunag @Mugen87 @LeviPesin