Don't force node matrixAutoUpdate to true in the gltf animation loader #24284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @takahirox do you recall why this is here? I don't remember, so fine with me to remove if the skinning examples are still working without it. |
|
No idea why we did it... And coincidentally I was going to suggest to remove the line, too, because Mozilla Hubs manages matrices updates by our selves. |
takahirox
approved these changes
Jun 29, 2022
donmccurdy
approved these changes
Jul 5, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
snagy
added a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The glTF loader was setting matrixAutoUpdate to 'true' on any node that's used as part of an animation. This ignores the object3d DefaultMatrixAutoUpdate setting, and causes problems if folks are trying to manage their updates themselves. Removed the line that sets the autoupdate, so instead animation nodes will follow the default setting.
This code doesn't exist in any other loaders.
All the animation samples still work. Most projects won't be affected because the default auto update setting is 'true'.
This contribution is funded by Meta