Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: Nodes examples clean up #24394

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Examples: Nodes examples clean up #24394

merged 1 commit into from
Jul 28, 2022

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Jul 28, 2022

FYI @sunag

@mrdoob mrdoob added this to the r143 milestone Jul 28, 2022
@mrdoob mrdoob merged commit 3f2c29b into dev Jul 28, 2022
@mrdoob mrdoob deleted the cleanup branch July 28, 2022 07:58
@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 28, 2022

@sunag I'm not sure this was previously reported but in the following warning occurs in webgl_nodes_materials_standard after the model has been loaded:

THREE.WebGLProgram: Program Info Log: WARNING: Output of vertex shader 'nodeVary4' not read by fragment shader
WARNING: Output of vertex shader 'webgl_9f946691f3bdd8ea' not read by fragment shader

@sunag
Copy link
Collaborator

sunag commented Jul 29, 2022 •
edited

@sunag I'm not sure this was previously reported but in the following warning occurs in webgl_nodes_materials_standard after the model has been loaded:

I still haven't been able to reproduce this warning.
For me, no warning happens.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 29, 2022

Maybe the warning is device related. I see this on a iMac with AMD GPU with Chrome 103.0.5060.134.

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
@mrdoob @abernier
Examples: Nodes examples clean up. (mrdoob#24394)
f0ff9d8
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
@mrdoob @snagy
Examples: Nodes examples clean up. (mrdoob#24394)
c92c491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r143
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrdoob @Mugen87 @sunag