Material: Remove deprecated FlatShading & SmoothShading constants. #24424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Aug 2, 2022
Mugen87
changed the title
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
…rdoob#24424) * Remove FlatShading & SmoothShading constants * Remove FlatShading & SmoothShading constants Co-authored-by: decuyper <Jeroen.decuyper@orbitus.be>
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
…rdoob#24424) * Remove FlatShading & SmoothShading constants * Remove FlatShading & SmoothShading constants Co-authored-by: decuyper <Jeroen.decuyper@orbitus.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #24418
Description
This PR removes all uses of the FlatShading & SmoothShading constants. these constants are deprecated since R87 but are not in the migration wiki. This commit removes the use of the constants by adding the property flatshading to the materials.