Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color: Support HSL(A) with decimal percentage values. #24461

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 7, 2022

Fixed #24441.

Description

Adds support for HSLA color definitions with decimal percentage values.

@WestLangley
Copy link
Collaborator

Nice. You also supported hsl(360,100.%,50.%) which I think is not supported in browsers.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Aug 8, 2022

Switching + and * did the trick.

@mrdoob mrdoob merged commit 7a0df35 into mrdoob:dev Aug 9, 2022
@mrdoob
Copy link
Owner

mrdoob commented Aug 9, 2022

Thanks!

@Mugen87 Mugen87 changed the title Color: Support HSLA with decimal percentage values. Color: Support HSL(A) with decimal percentage values. Aug 10, 2022
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* Color: Support HSLA with decimal percentage values.

* Color: Clean up.
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
* Color: Support HSLA with decimal percentage values.

* Color: Clean up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color: Support HSL percentage values with decimals.
3 participants