TrackballControls: Fix multi-touch in onTouchEnd().
#24631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem is observed on mobile phone, when lifting one finger after multitouch gesture, the camera will change dramatically as if swiped from that position to where first finger is
Mugen87
changed the title
onTouchEnd().
Mugen87
approved these changes
Sep 13, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* Fix camera runaway after zoom gesture problem is observed on mobile phone, when lifting one finger after multitouch gesture, the camera will change dramatically as if swiped from that position to where first finger is * Update TrackballControls.js Co-authored-by: Michael Herzog <michael.herzog@human-interactive.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: (Didn't raise an issue yet)
Description
When using trackball control on my mobile app, I discovered that camera position will suddenly change a lot after zoom/pan multi-touch gesture, this can be reproduced by running trackball sample on iOS or Android touch screen devices and perform a zoom/pan gesture with two fingers.
As diff shows, when lifting first finger, the
_moveCurrand_movePrevposition was assigned to the lifted finger, if move event is detected on the other finger, the camera position will change as user swipe from lifted position to other finger's position. I addressed it by assigning two position variables with other finger's position instead.I'm not a professional JS developer, so please feel free to edit / give me any suggestions : )