Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Remove exception for fog and background color #24929

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

donmccurdy
Copy link
Collaborator

Related:

Description

The Color Management guide previously called out fog, background color, and clear color as exceptions to the general rule that three.js APIs accepting THREE.Color instances assume RGB components in Linear-sRGB color space. For these properties, the choice had depended on renderer.outputEncoding and whether or not post-processing was used. The exception has been resolved with #23937, and these colors are no longer a special case when ColorManagement.legacyMode = false is configured (non-default in three.js, default in R3F).

@donmccurdy donmccurdy added this to the r147 milestone Nov 9, 2022
@Mugen87 Mugen87 merged commit f2fce01 into mrdoob:dev Nov 10, 2022
@donmccurdy donmccurdy deleted the docs/color-management-fog-background branch November 10, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants