NodeMaterial: Fix '_listeners' warning #25003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
reviewed
Nov 22, 2022
|
|
||
| nodeMaterial[ key ] = material[ key ]; // currently this is needed only for material.alphaTest | ||
| const nodeMaterial = new materialLib[ type ](); |
There was a problem hiding this comment.
I'm not sure about this... new materialLib[ type ]( material ) internally uses Material.setValues( material ), which copies values not only by simply assigning, but also via .copy(), but also produces a warning if there is not a key in new material (NodeMaterial).
Maybe we can add an option to that function to disable warnings? /cc @mrdoob @Mugen87
There was a problem hiding this comment.
Or maybe we can add _listeners as an exception in Material.setValues.
There was a problem hiding this comment.
Hmm... The point is that .fromMaterial() can be used outside of WebGPURenderer, but for WebGPURenderer is good not copy/clone to not add unnecessary duplicity in memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @LeviPesin
This contribution is funded by Google