Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance optimization by optionally sharing matrix between child & parent #25142

Closed
wants to merge 31 commits into from
Closed

Performance optimization by optionally sharing matrix between child & parent #25142

wants to merge 31 commits into from

Commits on Dec 10, 2022

  1. set quaternion, not rotation

    @diarmidmackenzie
    diarmidmackenzie committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    1ba542c View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2022

  1. Add more varied test

    @diarmidmackenzie
    diarmidmackenzie committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    338ac1c View commit details
    Browse the repository at this point in the history

  2. Base implementation of new class

    @diarmidmackenzie
    diarmidmackenzie committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    9a9e540 View commit details
    Browse the repository at this point in the history

  3. Replace updateMatrixWorld 

    Perf not looking great - linked list probably not a good solution as deciding when to stop traversing is too expensive.
    @diarmidmackenzie
    diarmidmackenzie committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    03fd59d View commit details
    Browse the repository at this point in the history

  4. Replace linked list data structure with arrays of children 

    Linked list was performing worse, not better.
    @diarmidmackenzie
    diarmidmackenzie committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    e601f18 View commit details
    Browse the repository at this point in the history

  5. Move position, quaternion, scale into Object3DMatrixData 

    Saves having to reference data on Object3D during updateMatrix()
    @diarmidmackenzie
    diarmidmackenzie committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    5dfe383 View commit details
    Browse the repository at this point in the history

  6. Fix bug: Index needed on removal

    @diarmidmackenzie
    diarmidmackenzie committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    b67cb24 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. Updated set of tests based on latest analysis of what variables matter.

    @diarmidmackenzie
    diarmidmackenzie committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    8c8b91c View commit details
    Browse the repository at this point in the history

  2. Fix warnings

    @diarmidmackenzie
    diarmidmackenzie committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    fffb64d View commit details
    Browse the repository at this point in the history

  3. Revert "set quaternion, not rotation" 

    This reverts commit 1ba542c.
    @diarmidmackenzie
    diarmidmackenzie committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    4b8a601 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. 1st attempt at code to fuse matrix with parent

    @diarmidmackenzie
    diarmidmackenzie committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    6112883 View commit details
    Browse the repository at this point in the history

  2. Fix bug that caused recursion

    @diarmidmackenzie
    diarmidmackenzie committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    5cd1aa1 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Merge branch 'dev' into Object3dMatrixData

    @diarmidmackenzie
    diarmidmackenzie committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    ba2142b View commit details
    Browse the repository at this point in the history

  2. Fix linting errors

    @diarmidmackenzie
    diarmidmackenzie committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    4e42f40 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'Object3dMatrixData' of https://github.com/diarmidmacken… 

    …zie/three.js into Object3dMatrixData
    @diarmidmackenzie
    diarmidmackenzie committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    fc4747a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'Object3dMatrixData' into fuse-matrix-with-parent

    @diarmidmackenzie
    diarmidmackenzie committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    a996c58 View commit details
    Browse the repository at this point in the history

  5. Fix lint errors

    @diarmidmackenzie
    diarmidmackenzie committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    7c8909e View commit details
    Browse the repository at this point in the history

  6. Fix merge error

    @diarmidmackenzie
    diarmidmackenzie committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    747a047 View commit details
    Browse the repository at this point in the history

  7. Fix up extensions of updateMatrixWorld()

    @diarmidmackenzie
    diarmidmackenzie committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    86b9aa8 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'perf-benchmark-realism' into Object3dMatrixData-fix-sub… 

    …classes
    @diarmidmackenzie
    diarmidmackenzie committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    cc36d5f View commit details
    Browse the repository at this point in the history

  9. Fix lint errors

    @diarmidmackenzie
    diarmidmackenzie committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    8844e02 View commit details
    Browse the repository at this point in the history

  10. Reference to parent object not actually needed 

    This also broke unit tests as it creates infinite recursion when comparing objects.
    @diarmidmackenzie
    diarmidmackenzie committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    64e7b39 View commit details
    Browse the repository at this point in the history

  11. Move setUpdateMatrixWorldBefore call to correct constructor

    @diarmidmackenzie
    diarmidmackenzie committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    70247a4 View commit details
    Browse the repository at this point in the history

  12. Move setUpdateMatrixWorldBefore call to correct constructor 

    Fixes example webgl_loader_mmd
    @diarmidmackenzie
    diarmidmackenzie committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    58562b3 View commit details
    Browse the repository at this point in the history

  13. New method for extending updateMatrixWorld()

    @diarmidmackenzie
    diarmidmackenzie committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    267e12c View commit details
    Browse the repository at this point in the history

  14. Remove unused code. 

    Code left over from having started with a slightly different implementation for extending updateMatrixWorld().  Can be removed now.
    @diarmidmackenzie
    diarmidmackenzie committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    fc5289b View commit details
    Browse the repository at this point in the history

  15. Merge branch 'Object3dMatrixData' into fuse-matrix-with-parent

    @diarmidmackenzie
    diarmidmackenzie committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    3934cf9 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Progress towards working version of merged matrices

    @diarmidmackenzie
    diarmidmackenzie committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    dc88913 View commit details
    Browse the repository at this point in the history

  2. Remove not-needed data structure 

    Left over from an earlier implementation attempt.
    @diarmidmackenzie
    diarmidmackenzie committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    01e5e69 View commit details
    Browse the repository at this point in the history

  3. Fix bug removing children while looping over them.

    @diarmidmackenzie
    diarmidmackenzie committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    68341d4 View commit details
    Browse the repository at this point in the history

  4. Fix linting

    @diarmidmackenzie
    diarmidmackenzie committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    e050c8e View commit details
    Browse the repository at this point in the history