Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/Examples/Manual: Keep focus when clear search input. #25194

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

abernier
Copy link
Contributor

@abernier abernier commented Dec 24, 2022

This was constantly annoying me, especially on mobile1...

BEFORE: In the search field, when clearing my query (with the X button), I lost the focus and have to click on the field again (at 00:07 in the 1st screencast) to type another query

exitSearchButton.mp4

AFTER: I keep the focus and can continue typing a different query

clearSearchButton.mp4

NB: I've renamed (in a separate commit) the X button from exitSearchButton to clearSearchButton just to better reflect what it is now doing

Footnotes

  1. especially on mobile because we cannot ctrl+a easily with the virtual keyboard. But tbh loosing focus was also annoying me on desktop if using the X button

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 30, 2022

@Mugen87 Mugen87 added this to the r149 milestone Dec 30, 2022
@Mugen87 Mugen87 changed the title inputFilter clear Docs/Examples/Manual: Keep focus when clear search input. Dec 30, 2022
@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 3, 2023

Normally I merge documentation related PRs but since this is a design/usability related issue, it's best if @mrdoob has a look at it first.

@mrdoob
Copy link
Owner

mrdoob commented Jan 5, 2023

Looks good!

@mrdoob mrdoob merged commit db3374b into mrdoob:dev Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants