WebXRManager: Allow early set of foveation.
#25282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently foveation is set to 1.0 on setSession, and there's no way to set it before, because it's not saved anywere when session is not active. So the only way to set it to a non-default value is to call setSession and call setFoveation afterwards. That leads to hacks in certain scenarios like pmndrs/react-xr#235. This PR allows setting it beforehand, while being backwards compatible
Mugen87
changed the title
foveation.
Mugen87
approved these changes
Jan 14, 2023
0b5vr
added a commit
to 0b5vr/three-ts-types
that referenced
this pull request
Jan 30, 2023
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently foveation is set to 1.0 on setSession, and there's no way to set it before, because it's not saved anywere when session is not active. So the only way to set it to a non-default value is to call setSession and call setFoveation afterwards. That leads to hacks in certain scenarios like pmndrs/react-xr#235. This PR allows setting it beforehand, while being backwards compatible
This contribution is funded by Mayflower