PropertyBinding: Remove fallback to root node on incorrect path names. #25329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Jan 24, 2023
|
Could you clarify what that means in practice – it's going to get merged after r149 becomes live? |
|
Yes, I suggest to merge the PR after |
Mugen87
changed the title
|
This commit broke our application. The relevant part of our application is here: which loads animation keyframes from shared GLB, and applies it to a set of avatar models created on Ready Player Me. Perhaps falling back to root may be wrong but setting targetObject to be null seems to be also wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Description
Currently, incorrect path names in property bindings can lead to confusing results, as ALL properties that can't be matched are instead applied to the root of the animation. This PR removes the fallbacks for that; instead, an error will be logged (as before) for those specific tracks but remaining tracks will work fine.
This contribution is funded by Needle