GLTFLoader: Fix node parse #25377
Merged
GLTFLoader: Fix node parse #25377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a GLTFLoader node parse bug that can cause an infinite loop in node parse - skin parse - node parse. The solution is adding ._loadNode() that parses a single node without child nodes or skin to the parser. .loadNode() and .loadSkin() call ._loadNode() to get dependent nodes. ._loadNode() doesn't have dependency with other nodes so infinite loop can be avoided. ._loadNode() caches created nodes to avoid duplication because it is called from two different methods, .loadNode() and .loadSkin().
takahirox
force-pushed
the
FixGLTFLoaderNodeParse
branch
from
5545dba
to
2ba9aac
Compare
donmccurdy
reviewed
Jan 31, 2023
This commit renames _loadNode to _loadNodeShallow. The behavior of the method is more clarified by the new name so remove a commend that sounds like duplicated with the method name (and also sounds like a bit misleading).
takahirox
force-pushed
the
FixGLTFLoaderNodeParse
branch
from
5fc253a
to
1cf338e
Compare
donmccurdy
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #25332.
Description
This commit fixes a
GLTFLoadernode parse bug that can cause an infinite loop in node parse - skin parse - node parse.The solution is adding
._loadNode()that parses a single node without child nodes or skin to the parser..loadNode()and.loadSkin()call._loadNode()to get dependent nodes.._loadNode()doesn't have dependency with other nodes so infinite loop can be avoided.._loadNode()caches created nodes to avoid duplication because it is called from two different methods,.loadNode()and.loadSkin()./cc @donmccurdy