GLTFLoader: Remove IIFE closures
#25416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes IIFE closures in loadNode() and loadNodeShallow() in GLTFLoader because they don't look like really necessary.
takahirox
force-pushed
the
GLTFLoaderRemoveClosure
branch
from
b4789a3
to
955c13d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related comment: #25377 (review)
Description
This PR removes IIFE closures in
loadNode()andloadNodeShallow()inGLTFLoaderbecause they don't look like really necessary.They seem to have been originally introduced at some point for a certain reason but I couldn't track. Perhaps outdated.