New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLRenderer: Use ES6 default parameter in `setSize()`. #25486

Merged

Mugen87 merged 2 commits into mrdoob:dev from linbingquan:dev-webgl-renderer

Feb 15, 2023

Contributor

linbingquan commented Feb 12, 2023

Related issue: #XXXX

Description

As the title.


          WebGLRenderer: use ES6 default value for setSize

415b202

Contributor

epreston commented Feb 12, 2023 •

edited

Wouldn't the default value be false if its not provided ? This changes the default to true to optimise an "if" statement.

Collaborator

gkjohnson commented Feb 12, 2023 •

edited

Wouldn't the default value be false if its not provided ?

The current default is undefined which amounts to true since undefined !== false when evaluating with triple equals.

Contributor

epreston commented Feb 12, 2023

Oh wow.. that is hairy. Worth a cleanup to make it readable. 😄

Mugen87 added this to the r150 milestone

Mugen87 reviewed

View reviewed changes

src/renderers/WebGLRenderer.js Outdated Show resolved Hide resolved


          make more explicit style

7de6cda

Mugen87 approved these changes

View reviewed changes

Collaborator

Mugen87 commented Feb 15, 2023 •

edited

BTW: We are already using the PR's approach in WebGPURenderer.setSize() and the other renderers do not have a updateStyle parameter.

Mugen87 merged commit 742b033 into mrdoob:dev

Mugen87 changed the title ~~WebGLRenderer: use ES6 default value for setSize~~ WebGLRenderer: Use ES6 default parameter in setSize().

linbingquan deleted the dev-webgl-renderer branch

August 19, 2023 11:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment