Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box2, Box3: Refactor distanceToPoint(). #25547

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

ycw
Copy link
Contributor

@ycw ycw commented Feb 22, 2023

:)

@Mugen87 Mugen87 added this to the r150 milestone Feb 22, 2023
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 22, 2023

:)

Don't want to be a drag but instead of a smiley it's better to explain what the PR actually does (like in your other PRs). In this way it's not necessary to check the code first. Hence:

This_PR simplifies the implementation of distanceToPoint() in Box2 and Box3 by reusing existing math methods instead of inlining the code.

@ycw
Copy link
Contributor Author

ycw commented Feb 22, 2023

roger that

@Mugen87 Mugen87 changed the title Box2, Box3: cleanup .distanceToPoint Box2, Box3: cleanup distanceToPoint(). Feb 22, 2023
@Mugen87 Mugen87 changed the title Box2, Box3: cleanup distanceToPoint(). Box2, Box3: Refactor distanceToPoint(). Feb 22, 2023
@mrdoob mrdoob merged commit 26c734d into mrdoob:dev Feb 23, 2023
@ycw ycw deleted the cleanup-box-distancetopoint branch February 24, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants