Cleanup code in css3d_molecules example #25587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Mar 1, 2023
| bond.style.height = bondLength + 'px'; | ||
|
|
||
| const joint = new THREE.Object3D( bond ); | ||
| const joint = new THREE.Object3D(); |
There was a problem hiding this comment.
As far as I can tell, passing an HTML element in an Object3D constructor doesn't do anything.
Good catch! However, bond is later used in the code to create another instance of CSS3DObject. And it's not right that multiple objects share the same DOM element. So please restore the bond creation and just remove the parameter from the ctor call of Object3D.
There was a problem hiding this comment.
🤦 Indeed. I moved the creation of the new bond element closer to its usage if that's okay.
Methuselah96
force-pushed
the
examples-css3d-molecules-cleanup
branch
from
6c859b4
to
fe98e9a
Compare
Methuselah96
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: N/A
Description
As far as I can tell, passing an HTML element in an Object3D constructor doesn't do anything.