Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BufferGeometryUtils: Simplify function names #25652

Merged
merged 4 commits into from Mar 11, 2023
Merged

BufferGeometryUtils: Simplify function names #25652

merged 4 commits into from Mar 11, 2023

Conversation

WestLangley
Copy link
Collaborator

BufferGeometryUtils.interleaveAttributes() exists, so the following changes are consistent with current nomenclature:

mergeBufferGeometries() -> mergeGeometries()
mergeBufferAttributes() -> mergeAttributes()

@WestLangley WestLangley added this to the r151 milestone Mar 11, 2023
@WestLangley
Copy link
Collaborator Author

I will do necessary clean-up of warnings in a follow-on PR.

@Mugen87 Mugen87 merged commit ee9a686 into mrdoob:dev Mar 11, 2023
16 checks passed
@WestLangley WestLangley deleted the dev-buffer_geo_utils branch March 11, 2023 18:55
@WestLangley WestLangley mentioned this pull request Mar 11, 2023
Merged
@Methuselah96 Methuselah96 mentioned this pull request Apr 25, 2023
Closed
37 tasks
@mtsmfm mtsmfm mentioned this pull request Aug 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r151
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WestLangley @Mugen87