MMDLoader: Catch parser exceptions. #25966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirox
approved these changes
Apr 30, 2023
Mugen87
changed the title
GitHubDragonFly
added a commit
to GitHubDragonFly/GitHubDragonFly.github.io
that referenced
this pull request
May 1, 2023
- Catch parser errors as per mrdoob/three.js#25966
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In MMDLoader, the exceptions from mmd-parser are not sent onError function, for example, this is one exception from mmd-parser: https://github.com/takahirox/mmd-parser/blob/master/src/Parser.js#L523 . This PR resends all the errors to onError function