Cleanup wegl_gpgpu_water #26436
Merged
Cleanup wegl_gpgpu_water #26436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sometimes it is required though to assign properties to a shader material so the renderer is able to generate GLSL defines. This is not true in this case so it's okay to clean things up. |
|
Good to know, any examples you can point to so I know what to look out for? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: N/A
Description
The
wegl_gpgpu_waterassigns properties toShaderMaterialthat aren't actual properties of aShaderMaterial. The more straightforward approach seems to assign those values directly to the uniforms.