Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectionHelper: Add enabled property. #26482

Closed
wants to merge 3 commits into from
Closed

SelectionHelper: Add enabled property. #26482

wants to merge 3 commits into from

Conversation

puxiao
Copy link
Contributor

@puxiao puxiao commented Jul 24, 2023

At some point I need to disable or enable SelectionHelper, but SelectionHelper currently only has .dispose() , and if I want to reactivate, I have to renew SelectionHelper() , so I added .enabled.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 24, 2023

I'm afraid this is an unusual pattern for the library. How about adding an enabled property instead?

@puxiao puxiao changed the title SelectionHelper: add reactive() SelectionHelper: add .enabled Jul 24, 2023
@Mugen87 Mugen87 changed the title SelectionHelper: add .enabled SelectionHelper: Add enabled property. Jul 24, 2023
@Mugen87 Mugen87 added this to the r155 milestone Jul 24, 2023
Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@puxiao puxiao closed this by deleting the head repository Jul 24, 2023
@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 24, 2023

Why did you close the PR?

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 24, 2023

Oh, it seems you have deleted your branch...

@puxiao
Copy link
Contributor Author

puxiao commented Jul 24, 2023

Operation error....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants