Docs: Improve OrbitControls page.
#26541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to add Sidenote: At least we can generate screenshots on macOS again 🎉 . |
WestLangley
reviewed
Aug 5, 2023
| @@ -91,7 +91,7 @@ <h2>Properties</h2> | |||
| <h3>[property:Boolean autoRotate]</h3> | |||
| <p> | |||
| Set to true to automatically rotate around the target.<br> Note that if this is enabled, you must call [page:.update] | |||
| () in your animation loop. | |||
| () in your animation loop. If you want the animation to be frame rate independent, apply a time delta value to [page:.update](). | |||
There was a problem hiding this comment.
How about something like this, instead...
If you want the auto-rotate speed to be independent of the frame rate (the refresh rate of the display), you must pass the time deltaTime, in seconds, to page.update().
There was a problem hiding this comment.
That sounds good to me! Do you mind updating the doc pages with your suggestion?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #26472
Description
Honors the latest changes of
OrbitControlsin the doc page.