Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Improve WebGPURenderer with antialias: true #26649

Merged
merged 2 commits into from
Aug 27, 2023

Conversation

linbingquan
Copy link
Contributor

Related issue: #XXXX

Description

As the title.

@sunag sunag added this to the r156 milestone Aug 27, 2023
@sunag sunag merged commit a2df762 into mrdoob:dev Aug 27, 2023
18 checks passed
@linbingquan
Copy link
Contributor Author

linbingquan commented Aug 27, 2023

@sunag Why there WebGPU examples does not enable the antialias flag. Maybe WebGPURenderer does not support it or I am miss something about it.

renderer = new WebGPURenderer( /*{ antialias: true }*/ );

renderer = new WebGPURenderer( /*{ antialias: true }*/ );

@sunag
Copy link
Collaborator

sunag commented Aug 27, 2023

The example has an incompatibility with the Renderer.copyFramebufferToTexture() method, this can be fixed, I just commented so I could merger the PR, the other example I think I commented by mistake.

sunag added a commit that referenced this pull request Aug 27, 2023
@linbingquan linbingquan deleted the dev-examples-webgpu branch August 29, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants