Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KTX2Loader: Fix regression with 3D textures. #26679

Merged
merged 3 commits into from
Sep 4, 2023
Merged

KTX2Loader: Fix regression with 3D textures. #26679

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76a81c4
KTX2Loader: fix data textures
vlucendo Aug 31, 2023
3a789fe
remove redundant mipmap assignment
vlucendo Aug 31, 2023
f234bb4
use first mipmap unconditionally
vlucendo Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions examples/jsm/loaders/KTX2Loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,17 +865,15 @@ async function createRawTexture( container ) {
if ( UNCOMPRESSED_FORMATS.has( FORMAT_MAP[ vkFormat ] ) ) {

texture = container.pixelDepth === 0
? new DataTexture( mipmaps, container.pixelWidth, container.pixelHeight )
: new Data3DTexture( mipmaps, container.pixelWidth, container.pixelHeight, container.pixelDepth );
? new DataTexture( mipmaps[ 0 ].data, container.pixelWidth, container.pixelHeight )
: new Data3DTexture( mipmaps[ 0 ].data, container.pixelWidth, container.pixelHeight, container.pixelDepth );

} else {

if ( container.pixelDepth > 0 ) throw new Error( 'THREE.KTX2Loader: Unsupported pixelDepth.' );

texture = new CompressedTexture( mipmaps, container.pixelWidth, container.pixelHeight );



}

texture.mipmaps = mipmaps;
Expand Down