USDZLoader: Switch to MeshPhysicalMaterial and add initial clearcoat/clearcoatRoughness/ior support #26713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
reviewed
Sep 7, 2023
Mugen87
approved these changes
Sep 7, 2023
|
Ops, this one has conflicts now... |
…tRoughness/ior support fix incorrect colorspace usage
hybridherbst
force-pushed
the
feature/usdzloader-clearcoat
branch
from
488287e
to
70c43c5
Compare
|
Should be fixed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
This PR should be merged after
Description
Switches USDZLoader to MeshPhysicalMaterial and adds loading support for clearcoat/clearcoatRoughness.
These parameters are already exported by USDZExporter.
Some details seem to be wrong, but I currently suspect GLTFLoader not loading the clearcoat test file correctly in the first place (will report a separate issue).
USDZ loaded into Mac QuickLook
USDZ loaded into three.js
Test file: ClearCoatTest.zip
This contribution is funded by Needle