Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USDZLoader: Fix index array type. #26751

Merged
merged 2 commits into from Sep 13, 2023
Merged

USDZLoader: Fix index array type. #26751

merged 2 commits into from Sep 13, 2023

Conversation

GitHubDragonFly
Copy link
Contributor

Related issue: No reported issue that I could find

Description

  • Current Uint16Array type might cause spaghetti-like effect when opening some USDZ models
  • Changed to Uint32Array type
  • This can be tested with the coffeemat.glb example by opening it in the current r157dev editor, exporting it as a USDZ file and then opening the exported file in the same editor.

The following pictures show before and after effects.

USDZ - Uint16Array Index
USDZ - Uint32Array Index

- Current `Uint16Array` type might cause spaghetti-like effect when opening some USDZ models
- Changed to `Uint32Array` type
@Mugen87 Mugen87 added this to the r157 milestone Sep 13, 2023
@Mugen87 Mugen87 changed the title USDZ Loader - fix index array type USDZLoader: Fix index array type. Sep 13, 2023
@Mugen87 Mugen87 merged commit b25c90c into mrdoob:dev Sep 13, 2023
18 checks passed
@GitHubDragonFly GitHubDragonFly deleted the usdz_update branch September 19, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants